Wrap the quadrature floating-point numbers in the macro DUNE_NUMBER_FROM_STRING

Summary

The maxima script to generate 1d quadrature rules produces two copies of the same code: one with floating point numbers, one with strings. While it is generated automatically, it is a lot of code duplication that is actually not necessary. Also for future high-precision rules, duplicating all the code is not a proper solution. This MR introduces a small helper macro that expands the argument to both, a floating point constant and a string. Additionally a helper function is introduced to convert from the two generated arguments to the output type.

Discussion

The floating-point number type is currently fixed to double. Actually, one could pass the numbers as long double by adding the literal suffix L. Unfortunately, the GMPField type does not allow to be constructed from string representations of numbers that include any suffix. Thus, one would have to workaround this, e.g., by stripping off any suffix before passing to the constructor of the number type.

changed the description

changed title from Wrap the quadrature floating-point numbers in the macro DUNE_NUMBERS to Wrap the quadrature floating-point numbers in the macro DUNE_NUMBER

mentioned in issue #9

DUNE_NUMBER is a rather generic name. Can we use something more specific, e.g. DUNE_NUMBER_FROM_STRING?

added 49 commits

• b4cf9e4f...bca0f2bf - 48 commits from branch master
• 8548e3fa - wrap the quadrature floating-point numbers in the macro DUNE_NUMBER_FROM_STRING

Compare with previous version

resolved all threads

changed title from Wrap the quadrature floating-point numbers in the macro DUNE_NUMBER to Wrap the quadrature floating-point numbers in the macro DUNE_NUMBER_FROM_STRING

added 1 commit

• f1e97692 - wrap the quadrature floating-point numbers in the macro DUNE_NUMBER_FROM_STRING

Compare with previous version

added 1 commit

• a93cdfc7 - Add license header

Compare with previous version

resolved all threads

Is this utility numberToString useful in your opinion? I think this MR is ready to be merged.

I would like to merge this soon. Any objections?

approved this merge request

resolved all threads

mentioned in commit ed77a750

merged