Fix saving feedback

app.py

@@ -12,6 +12,8 @@ from huggingface_hub import CommitScheduler
 
 # TODO make it so that feedback is only saved on prev. example if user makes another obfuscation
 # and changes slider but doesn't hit obfuscate
+# TODO maybe make it save and reset if user hits submit feedback
+# TODO sampling params for modles
 
 MODEL_PATHS = {
     "length_more": "hallisky/lora-length-long-llama-3-8b",
@@ -24,7 +26,7 @@ MODEL_PATHS = {
 
 DESCRIPTION = """\
 # Authorship Obfuscation
-This Space demonstrates model [Llama-2-7b-chat](https://huggingface.co/meta-llama/Llama-2-7b-chat) by Meta, a Llama 2 model with 7B parameters fine-tuned for chat instructions. Feel free to play with it, or duplicate to run generations without a queue! If you want to run your own service, you can also [deploy the model on Inference Endpoints](https://huggingface.co/inference-endpoints).
+This Space demonstrates StyleRemix, a Llama 3 model with 8B parameters fine-tuned for chat instructions. Feel free to play with it, or duplicate to run generations without a queue! If you want to run your own service, you can also [deploy the model on Inference Endpoints](https://huggingface.co/inference-endpoints).
 🔎 For more details about the Llama 2 family of models and how to use them with `transformers`, take a look [at our blog post](https://huggingface.co/blog/llama2).
 🔨 Looking for an even more powerful model? Check out the [13B version](https://huggingface.co/spaces/huggingface-projects/llama-2-13b-chat) or the large [70B model demo](https://huggingface.co/spaces/ysharma/Explore_llamav2_with_TGI).
 """
@@ -41,7 +43,6 @@ if torch.cuda.is_available():
     tokenizer = AutoTokenizer.from_pretrained(model_id)
 
 # Global variable to store the latest obfuscation result
-latest_obfuscation = {}
 user_id = str(uuid4())  # Generate a unique session-specific user ID
 
 JSON_DATASET_DIR = Path("json_dataset")
@@ -63,13 +64,10 @@ def save_data(data):
             json.dump(data, f)
             f.write("\n")
 
-def save_feedback(feedback_rating, feedback_text):
-    global latest_obfuscation
-    if latest_obfuscation:
-        feedback_data = latest_obfuscation.copy()
-        feedback_data["feedback_rating"] = feedback_rating
-        feedback_data["feedback_text"] = feedback_text
-        save_data(feedback_data)
+def save_feedback(feedback_rating, feedback_text, latest_obfuscation):
+    latest_obfuscation["feedback_rating"] = feedback_rating
+    latest_obfuscation["feedback_text"] = feedback_text
+    save_data(latest_obfuscation)
     return "No Feedback Selected", ""
 
 @spaces.GPU
@@ -125,7 +123,7 @@ def greet(input_text, length, function_words, grade_level, sarcasm, formality, v
     # Save the obfuscation result
     save_data(latest_obfuscation)
     
-    return response, gr.update(interactive=True), gr.update(interactive=True)
+    return response, gr.update(interactive=True), gr.update(interactive=True), latest_obfuscation
 
 def reset_sliders():
     return [0.5] * 7 + [0] * 3
@@ -161,6 +159,7 @@ def check_initial_feedback_state(feedback_rating, feedback_text):
 demo = gr.Blocks()
 
 with demo:
+    latest_obfuscation = gr.State({})
     gr.Markdown(DESCRIPTION)
     with gr.Row():
         with gr.Column(variant="panel"):
@@ -242,7 +241,10 @@ with demo:
             gr.Markdown("### Provide any feedback on the obfuscation")
             feedback_text = gr.Textbox(label="Feedback", lines=3, interactive=False)
 
-            obfuscate_button.click(fn=greet, inputs=[input_text] + sliders, outputs=[output, feedback_rating, feedback_text])
+            obfuscate_button.click(
+                fn=greet, 
+                inputs=[input_text] + sliders, 
+                outputs=[output, feedback_rating, feedback_text, latest_obfuscation])
 
             save_feedback_button = gr.Button("Save Feedback", interactive=False)
             feedback_warning_message = gr.Markdown(
@@ -255,7 +257,7 @@ with demo:
 
             save_feedback_button.click(
                 fn=save_feedback,
-                inputs=[feedback_rating, feedback_text],
+                inputs=[feedback_rating, feedback_text, latest_obfuscation],
                 outputs=[feedback_rating, feedback_text]
             )
             # Initialize the save feedback button and warning message state on page load